search

datalad / datalad-crawler

DataLad extension for tracking web resources as datasets
http://datalad.org
Other
5 stars 16 forks source link

MNT: Adjust imports for compatibility with developmental DataLad #53

Closed kyleam closed 5 years ago

kyleam commented 5 years ago

datalad.downloaders.base doesn't do a blanket import of datalad.support.exceptions as of DataLad's 22392ddfc (RF: Discontinue evil 'import *', 2019-08-26). As a result, UnhandledRedirectError and TargetFileAbsent are no longer defined in downloaders.base.

Get exceptions from where they're defined rather than relying on downloaders.base to have them.

codecov[bot] commented 5 years ago

Codecov Report

Merging #53 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files          53       53           
  Lines        4243     4243           
=======================================
  Hits         3643     3643           
  Misses        600      600
Impacted Files Coverage Δ
datalad_crawler/nodes/crawl_url.py 90.24% <100%> (ø) :arrow_up:
datalad_crawler/nodes/s3.py 27.81% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b9dc83...ebdcd73. Read the comment docs.