search

datalad / datalad-crawler

DataLad extension for tracking web resources as datasets
http://datalad.org
Other
5 stars 16 forks source link

RF: Discontinue use of GitRepo._git_custom_command() and _annex_custom_command #82

Closed mih closed 3 years ago

mih commented 3 years ago

The method will vanish. GitRepo.call_git() is now used instead. It was introduced with DataLad 0.12.

mih commented 3 years ago

All tests hang. This look like the test helper stalling, while waiting for a git-annex batch to finish (which never will). This was addressed by https://github.com/datalad/datalad/pull/4829/commits/383819eafc77e604c9cea2977820dcd299ea2902 (part of https://github.com/datalad/datalad/pull/4829) and subsequent changes by @bpoldrack

yarikoptic commented 3 years ago

Reran 0.6.0 release tests on Travis: all green so these changes seems to resurface the stalling issue :-(

yarikoptic commented 3 years ago

oh well, https://github.com/datalad/datalad/pull/5013 was merged after recent 0.13.5, I will restart tests, they better do not stall. We then merge if green, release crawler -- would help to keep maint/master in check

yarikoptic commented 3 years ago

can't restart, will push some dummy merge or alike

codecov[bot] commented 3 years ago

Codecov Report

Merging #82 (2ff2fb6) into master (a6d5efc) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   81.37%   81.40%   +0.02%     
==========================================
  Files          57       57              
  Lines        4656     4652       -4     
==========================================
- Hits         3789     3787       -2     
+ Misses        867      865       -2
Impacted Files Coverage Δ
datalad_crawler/nodes/annex.py 80.87% <100.00%> (+0.17%) :arrow_up:
datalad_crawler/pipelines/tests/test_openfmri.py 89.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6d5efc...2ff2fb6. Read the comment docs.

yarikoptic commented 3 years ago

oh, and magically stalls disappeared for this run -- let's cherish the moment. Soon releases will be automated (#86) but for now I will just proceed "manually"