search

datalad / datalad-crawler

DataLad extension for tracking web resources as datasets
http://datalad.org
Other
5 stars 16 forks source link

RF: Discontinue use of feature exclusive to the old DataLad Runner #89

Closed mih closed 3 years ago

mih commented 3 years ago

The new one does not have the ability to "run" Python callables, nor does it support the old-style protocols.

This is a fairly blind RF attempt, without trying to understand in depth what role DryRunProtocol played (or plays in the crawler tests.

codecov[bot] commented 3 years ago

Codecov Report

Merging #89 (e56619b) into master (0cc2934) will decrease coverage by 0.00%. The diff coverage is 87.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   81.37%   81.37%   -0.01%     
==========================================
  Files          57       57              
  Lines        4656     4644      -12     
==========================================
- Hits         3789     3779      -10     
+ Misses        867      865       -2
Impacted Files Coverage Δ
datalad_crawler/base.py 100.00% <ø> (+20.00%) :arrow_up:
datalad_crawler/nodes/annex.py 80.76% <87.87%> (-0.12%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cc2934...e56619b. Read the comment docs.