Closed mih closed 3 years ago
Merging #28 (584b704) into master (425a8d0) will increase coverage by
3.70%
. The diff coverage is95.05%
.:exclamation: Current head 584b704 differs from pull request most recent head 9a02efa. Consider uploading reports for the commit 9a02efa to get more accurate results
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 84.43% 88.13% +3.70%
==========================================
Files 13 15 +2
Lines 1246 1913 +667
==========================================
+ Hits 1052 1686 +634
- Misses 194 227 +33
Impacted Files | Coverage Δ | |
---|---|---|
datalad_deprecated/__init__.py | 100.00% <ø> (ø) |
|
datalad_deprecated/publish.py | 88.21% <88.21%> (ø) |
|
datalad_deprecated/tests/test_publish.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 425a8d0...9a02efa. Read the comment docs.
All good!
Note that the failing "crippled FS" run is not a surprise, this run was never meant to work. it is more of a demonstration why this code lives in deprecated. The crippled FS CI in -core does not even execute these tests.
Given that this PR is specifically requested https://github.com/datalad/datalad/issues/4494#issuecomment-886715139, I think we can go ahead here.
Acting on the deprecation in 0.13: https://github.com/datalad/datalad/issues/4494
A companion PR in -core will be posted shortly.
Once merged, the issues listed in https://github.com/datalad/datalad/issues/4494 can be moved to this project.
Companion PR in -core is https://github.com/datalad/datalad/pull/5837