search

datalad / datalad-deprecated

DataLad extension for functionality that has been phased out of the core package
Other
0 stars 3 forks source link

Web UI title change #30

Closed dereklu888 closed 3 years ago

dereklu888 commented 3 years ago

Quick title change, currently sets the title as "Datalad Repository: firstfolder/secondfolder/lastfolder".

codecov-commenter commented 3 years ago

Codecov Report

Merging #30 (2700f09) into master (7bcb7d1) will not change coverage. The diff coverage is 95.05%.

:exclamation: Current head 2700f09 differs from pull request most recent head 6bc2fc9. Consider uploading reports for the commit 6bc2fc9 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   88.13%   88.13%           
=======================================
  Files          15       15           
  Lines        1913     1913           
=======================================
  Hits         1686     1686           
  Misses        227      227
Impacted Files Coverage Δ
datalad_deprecated/__init__.py 100.00% <ø> (ø)
datalad_deprecated/publish.py 88.21% <88.21%> (ø)
datalad_deprecated/tests/test_publish.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7bcb7d1...6bc2fc9. Read the comment docs.

yarikoptic commented 3 years ago

I think this is as good as it can get, no trimming would help really since on different browsers and different use cases (tab title vs what you see in the browser history/back button) etc it all would be "suboptimal" since no optimum exists or it should be done by the browser. So - let's proceed, thank you @dereklu888 !