search

datalad / datalad-deprecated

DataLad extension for functionality that has been phased out of the core package
Other
0 stars 3 forks source link

Made context menu button always visible #36

Closed dereklu888 closed 2 years ago

dereklu888 commented 2 years ago

In response to an issue in webui, the ... for the context menu is now always visible. This is just a minor css change.

codecov-commenter commented 2 years ago

Codecov Report

Merging #36 (f28fd52) into master (7bcb7d1) will not change coverage. The diff coverage is 95.05%.

:exclamation: Current head f28fd52 differs from pull request most recent head 85743d1. Consider uploading reports for the commit 85743d1 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   88.13%   88.13%           
=======================================
  Files          15       15           
  Lines        1913     1913           
=======================================
  Hits         1686     1686           
  Misses        227      227
Impacted Files Coverage Δ
datalad_deprecated/__init__.py 100.00% <ø> (ø)
datalad_deprecated/publish.py 88.21% <88.21%> (ø)
datalad_deprecated/tests/test_publish.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7bcb7d1...85743d1. Read the comment docs.

yarikoptic commented 2 years ago

ha -- RTD build failed which can't relate to this change.

Writing /tmp/easy_install-5o_09bhr/jsmin-2.2.2/setup.cfg
Running jsmin-2.2.2/setup.py -q bdist_egg --dist-dir /tmp/easy_install-5o_09bhr/jsmin-2.2.2/egg-dist-tmp-ihah4s_r
error: Setup script exited with error in jsmin setup command: use_2to3 is invalid.

checked https://readthedocs.org/projects/datalad/builds/ - all recent ones are good. so not sure what is about ATM.

In response to an issue in webui,

next time reference it here -- as

Closes https://github.com/datalad/datalad-webui/issues/8

A bright day will come whenever I finally move relevant code to that extension, uff

Change looks as expected on http://datasets-dev.datalad.org/ , so let's proceed. Any artistic improvement (I think may be with smaller size might align better) could be addressed later.