search

datalad / datalad-deprecated

DataLad extension for functionality that has been phased out of the core package
Other
0 stars 3 forks source link

Add external links to files (if available) and display in context menu #37

Closed dereklu888 closed 1 year ago

dereklu888 commented 2 years ago

Not finished, just adding a pr to keep track of progress.

Currently, the code adds an "external_urls" property that contains a list of external URLs to file metadata, but this has only been tested on a small dataset (templateflow's tpl-Fischer344).

Still need to do more testing and implement it on the webui side.

dereklu888 commented 2 years ago

Ok, did some more testing using tpl-Fischer344, the web UI portion seems to be working. However, I haven't done a full test, as in one smooth process from "datalad create-sibling" then doing "datalad push" yet. I've just been copying over the updated metadata file from my updated "datalad ls" over -- I think I'll need to integrate my updated "datalad ls" into "datalad push" somehow for that full test, I'll look into it!

(The attached photos show what it looks like when there's only 1 external URL and multiple external URLs. If there's multiple, it displays a max of 5 and lists each with their hostname)

image image

dereklu888 commented 2 years ago

Sorry for the delay, but I've been able to test a full create-sibling to push process using the latest datalad version (15.01), and got the external_urls going as shown above.

mih commented 2 years ago

@yarikoptic what are your plans here? Put in draft mode?

mih commented 2 years ago

I am putting this PR in draft mode.

yarikoptic commented 2 years ago

thanks @mih . I think changes are LGTM, I might try to find some time to test myself and deploy and merge then.

yarikoptic commented 1 year ago

after #51 is merged, I will merge master into this and ensure it breaks nothing and merge then

yarikoptic commented 1 year ago

eh, crippled fs fail seems related to the changes in PR so will need to get closer look

FAILED ../tests/test_ls_webui.py::test_fs_traverse - TypeError: argument of type 'NoneType' is not iterable
FAILED ../tests/test_ls_webui.py::test_ls_json - TypeError: argument of type 'NoneType' is not iterable
yarikoptic commented 1 year ago

Appveyor Mac fail is unrelated IMHO

Warning: Your Xcode (12.3) is outdated.
Please update to Xcode 12.4 (or delete it).
Xcode can be updated from the App Store.
github-actions[bot] commented 1 year ago

:rocket: PR was released in 0.3.0 :rocket: