search

datalad / datalad-deprecated

DataLad extension for functionality that has been phased out of the core package
Other
0 stars 3 forks source link

Import deprecated GitRepo.*_submodule() methods #38

Closed mih closed 2 years ago

mih commented 2 years ago

This methods are not used in -core for a long time.

The import includes their tests, as far as they existed.

https://github.com/datalad/datalad/pull/6010 is the -core companion PR that enables the usual type of automatic retro-fitting, whenever the -deprecated package is installed.

codecov-commenter commented 2 years ago

Codecov Report

Merging #38 (cc1ed81) into master (ea964e3) will decrease coverage by 2.45%. The diff coverage is 61.73%.

:exclamation: Current head cc1ed81 differs from pull request most recent head 44fe6ed. Consider uploading reports for the commit 44fe6ed to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   88.13%   85.68%   -2.46%     
==========================================
  Files          15       18       +3     
  Lines        1913     2109     +196     
==========================================
+ Hits         1686     1807     +121     
- Misses        227      302      +75
Impacted Files Coverage Δ
datalad_deprecated/gitrepo.py 0.00% <0.00%> (ø)
datalad_deprecated/tests/test_annexrepo.py 100.00% <100.00%> (ø)
datalad_deprecated/tests/test_gitrepo.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea964e3...44fe6ed. Read the comment docs.

mih commented 2 years ago

OK, let's proceed.