datalad / datalad-deprecated

DataLad extension for functionality that has been phased out of the core package
Other
0 stars 3 forks source link

`--missing=inherit` does not work for subdatasets with their supers not yet having that remote #41

Open yarikoptic opened 7 years ago

yarikoptic commented 7 years ago

I think we had that issue filed, but ... not sure which one ;)

$> datalad publish --to=datalad-public --missing=inherit --since=57589e03bb23c4f667161eaf29e2ab4b9aee96c0 -r
[INFO   ] Will try to create a sibling inheriting settings from <Dataset path=/mnt/btrfs/datasets/datalad/crawl/workshops/nih-2017/ds000114> 
[ERROR  ] <Dataset path=/mnt/btrfs/datasets/datalad/crawl/workshops/nih-2017/ds000114> had neither pushurl or url defined for datalad-public [create_sibling.py:_get_remote_url:684] (ValueError) 
datalad publish --to=datalad-public --missing=inherit  -r  6.30s user 5.66s system 52% cpu 22.972 total

that ds000114 was a dataset install from openfmri but extended with subdatasets (see datalad/datalad#1672 ). no url were defined since it had no remote with that name. But because we first publish deeper subdatsets, they could not consult their direct parents since those didn't have that remote set up yet either.

So I guess in such mode of --missing=inherit we would need first to do the pass from top to the deeper subdatasets to assure that all have the remote set, and then publish from deeper to the top

yarikoptic commented 5 years ago

duplicate of datalad/datalad-deprecated#33?

kyleam commented 5 years ago

duplicate of datalad/datalad-deprecated#33?

I suppose you, as the OP of both, would be in the best position to say.

yarikoptic commented 5 years ago

It is two different Yariks two months apart!