yarikoptic
commented
2 years ago something is odd with a test on crippled FS (FWIW: uses python 3.8) -- needs "looking into".
Closed yarikoptic closed 1 year ago
yarikoptic
commented
2 years ago something is odd with a test on crippled FS (FWIW: uses python 3.8) -- needs "looking into".
yarikoptic
commented
2 years ago and in a fresh PR #52 to see how master is doing with nose:
yarikoptic
commented
1 year ago windows and crippled and even ubuntu seems to error out with
collected 98 items / 1 error / 4 skipped
==================================================================================================================== ERRORS ====================================================================================================================
_________________________________________________________________________________________________ ERROR collecting metadata/extractors/xmp.py __________________________________________________________________________________________________
../../../dlvenv/lib/python3.8/site-packages/datalad_deprecated/metadata/extractors/xmp.py:20: in <module>
from libxmp.utils import file_to_dict
../../../dlvenv/lib/python3.8/site-packages/libxmp/__init__.py:50: in <module>
from .core import XMPMeta, XMPIterator
../../../dlvenv/lib/python3.8/site-packages/libxmp/core.py:50: in <module>
from . import exempi as _cexempi
../../../dlvenv/lib/python3.8/site-packages/libxmp/exempi.py:69: in <module>
EXEMPI = _load_exempi()
../../../dlvenv/lib/python3.8/site-packages/libxmp/exempi.py:60: in _load_exempi
raise ExempiLoadError('Exempi library not found.')
E libxmp.ExempiLoadError: Exempi library not found.looking into it
yarikoptic
commented
1 year ago many of "crippled" tests fail due to what looks like broken packaging of the datalad-deprecated as not shipping the test data
2022-09-29T14:26:19.5528040Z if not follow_symlinks and os.path.islink(src):
2022-09-29T14:26:19.5528328Z os.symlink(os.readlink(src), dst)
2022-09-29T14:26:19.5528555Z else:
2022-09-29T14:26:19.5528825Z > with open(src, 'rb') as fsrc:
2022-09-29T14:26:19.5529453Z E FileNotFoundError: [Errno 2] No such file or directory: '/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/site-packages/datalad_deprecated/metadata/tests/data/exif.jpg'
2022-09-29T14:26:19.5529771Z
2022-09-29T14:26:19.5529960Z /opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/shutil.py:120: FileNotFoundError
2022-09-29T14:26:19.5530575Z ------------------------------ Captured log call -------------------------------and in crippled we install via python -m pip install . so non-devel mode while in appveyor we do both
- python -m pip install -r requirements-devel.txt
- python -m pip install .and we have
$> head requirements-devel.txt
# requirements for a development environment
-e .[devel]so I guess we do test "in place" installation and thus finding the data files...
edit0: above observation is not the answer since it seems we do the same double pip install in both and also do testing from __testhome__ in both. so it is smth else but still smells with the bug in "packaging".
edit1: for now I will postpone troubleshooting of crippled and concentrate on making appveyor healthy again. For crippled, which would entail also fixing real issues which were introduced recently -- work better be done AFTER this PR is merged so we have consistent testing base.
yarikoptic
commented
1 year ago ha -- we do get the same problems now on appveyor ubuntu since we do test those metadata tests now. So clearly packaging needs to be fixed up... looking into it.
codecov-commenter
commented
1 year ago Base: 57.24% // Head: 80.37% // Increases project coverage by +23.12% :tada:
Coverage data is based on head (
ad17b01) compared to base (0ca142e). Patch coverage: 90.32% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
yarikoptic
commented
1 year ago woohoo -- appveyor is green .
also need to figure out why codecov is not reporting back, into statuses but it is known and shows above that we improve by 23% ;)
yarikoptic
commented
1 year ago ok -- it is very green. I will merge and release tomorrow unless any "stop" is voiced or feedback requiring changes is provided.
github-actions[bot]
commented
1 year ago :rocket: PR was released in 0.2.3 :rocket:
setup_packagebased on old nose based fixtures. But it is not enough due toassert_raisescontext manager has.valueinstead of.extensionand we import some tests from datalad core.skip_if_adjusted_branchinstead of just skipping on windowsCloses #66