search

datalad / datalad-deprecated

DataLad extension for functionality that has been phased out of the core package
Other
0 stars 3 forks source link

Properly include "data packages" in project #59

Closed jwodder closed 1 year ago

jwodder commented 2 years ago

There are several folders in datalad_deprecated/ that contain data files but no Python source code, and we want these to be included when datalad-deprecated is installed. Currently, these folders are automatically included by the combination of graft datalad_deprecated/resources in MANIFEST.in and include_package_data = True in setup.cfg, but because we set packages in setup.cfg to find: instead of find_namespace:, the folders themselves are not recognized by setuptools as packages. This combination of settings is deprecated, and the setuptools developers recommend using find_namespace: instead of find: for such situations.

yarikoptic commented 2 years ago

trying to fix up CI/testing in https://github.com/datalad/datalad-deprecated/pull/60 (pushed also docs fix directly) so we can see that there is no sideeffects somehow

yarikoptic commented 2 years ago

please rebase. I've merged https://github.com/datalad/datalad-deprecated/pull/60 and now only testing on crippled should fail

jwodder commented 2 years ago

@yarikoptic Rebased.

yarikoptic commented 1 year ago

as referenced above @christian-monch included this PR with some changes in another PR, and this PR should have been closed as superseded.