datalad / datalad-deprecated

DataLad extension for functionality that has been phased out of the core package
Other
0 stars 3 forks source link

Stop execution of crippled filesystems tests, inform the user about skipping them instead #64

Closed christian-monch closed 1 year ago

christian-monch commented 1 year ago

This PR stops the execution of the crippled filesystem-tests because they are mostly failing and not maintained. Their execution is therefore a waste of computation time.

We still generate a message to inform users that they have been disabled due to their unmaintained status. This might trigger a maintenance effort in the future

codecov-commenter commented 1 year ago

Codecov Report

Base: 57.24% // Head: 57.24% // No change to project coverage :thumbsup:

Coverage data is based on head (b797c64) compared to base (0ca142e). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #64 +/- ## ======================================= Coverage 57.24% 57.24% ======================================= Files 57 57 Lines 5380 5380 ======================================= Hits 3080 3080 Misses 2300 2300 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-deprecated/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [...alad\_deprecated/tests/test\_create\_sibling\_webui.py](https://codecov.io/gh/datalad/datalad-deprecated/pull/64/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9kZXByZWNhdGVkL3Rlc3RzL3Rlc3RfY3JlYXRlX3NpYmxpbmdfd2VidWkucHk=) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

yarikoptic commented 1 year ago

This PR stops the execution of the crippled filesystem-tests because they are mostly failing and not maintained

have you looked into what tests actually fail and why? (and may be when they started to fail?)

yarikoptic commented 1 year ago

let's consider superseded by #51 where they run and greenish? (some were skipped indeed, some fixed up)

christian-monch commented 1 year ago

This PR stops the execution of the crippled filesystem-tests because they are mostly failing and not maintained

have you looked into what tests actually fail and why? (and may be when they started to fail?)

I did not, @mih and I agreed on disabling them for the moment when looking into all PRs that were involved in the metadata code move. The plan was to pick it up again later, and I guess we forgot to create an appropriate issue.

yarikoptic commented 1 year ago

51 is merged and they are green ATM