datalad / datalad-deprecated

DataLad extension for functionality that has been phased out of the core package
Other
0 stars 3 forks source link

Add deprecated metadata config procedure from datalad core #78

Closed bpoldrack closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Base: 79.97% // Head: 90.15% // Increases project coverage by +10.18% :tada:

Coverage data is based on head (2a4a677) compared to base (8662b61). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #78 +/- ## =========================================== + Coverage 79.97% 90.15% +10.18% =========================================== Files 58 58 Lines 5347 5353 +6 =========================================== + Hits 4276 4826 +550 + Misses 1071 527 -544 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-deprecated/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_deprecated/conftest.py](https://codecov.io/gh/datalad/datalad-deprecated/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9kZXByZWNhdGVkL2NvbmZ0ZXN0LnB5) | `100.00% <100.00%> (ø)` | | | [...ted/metadata/extractors/tests/test\_datacite\_xml.py](https://codecov.io/gh/datalad/datalad-deprecated/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9kZXByZWNhdGVkL21ldGFkYXRhL2V4dHJhY3RvcnMvdGVzdHMvdGVzdF9kYXRhY2l0ZV94bWwucHk=) | `100.00% <100.00%> (ø)` | | | [datalad\_deprecated/metadata/metadata.py](https://codecov.io/gh/datalad/datalad-deprecated/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9kZXByZWNhdGVkL21ldGFkYXRhL21ldGFkYXRhLnB5) | `88.42% <100.00%> (+26.05%)` | :arrow_up: | | [...alad\_deprecated/metadata/tests/test\_aggregation.py](https://codecov.io/gh/datalad/datalad-deprecated/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9kZXByZWNhdGVkL21ldGFkYXRhL3Rlc3RzL3Rlc3RfYWdncmVnYXRpb24ucHk=) | `99.06% <100.00%> (+<0.01%)` | :arrow_up: | | [datalad\_deprecated/metadata/tests/test\_base.py](https://codecov.io/gh/datalad/datalad-deprecated/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9kZXByZWNhdGVkL21ldGFkYXRhL3Rlc3RzL3Rlc3RfYmFzZS5weQ==) | `99.26% <100.00%> (+0.01%)` | :arrow_up: | | [...deprecated/metadata/tests/test\_extract\_metadata.py](https://codecov.io/gh/datalad/datalad-deprecated/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9kZXByZWNhdGVkL21ldGFkYXRhL3Rlc3RzL3Rlc3RfZXh0cmFjdF9tZXRhZGF0YS5weQ==) | `100.00% <100.00%> (ø)` | | | [datalad\_deprecated/metadata/tests/test\_search.py](https://codecov.io/gh/datalad/datalad-deprecated/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9kZXByZWNhdGVkL21ldGFkYXRhL3Rlc3RzL3Rlc3Rfc2VhcmNoLnB5) | `98.67% <100.00%> (+<0.01%)` | :arrow_up: | | [...lad\_deprecated/metadata/extractors/datalad\_core.py](https://codecov.io/gh/datalad/datalad-deprecated/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9kZXByZWNhdGVkL21ldGFkYXRhL2V4dHJhY3RvcnMvZGF0YWxhZF9jb3JlLnB5) | `89.79% <0.00%> (+4.08%)` | :arrow_up: | | [datalad\_deprecated/metadata/extractors/xmp.py](https://codecov.io/gh/datalad/datalad-deprecated/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9kZXByZWNhdGVkL21ldGFkYXRhL2V4dHJhY3RvcnMveG1wLnB5) | `87.93% <0.00%> (+37.93%)` | :arrow_up: | | ... and [4 more](https://codecov.io/gh/datalad/datalad-deprecated/pull/78/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

bpoldrack commented 1 year ago

So, this time the branch was tested against https://github.com/datalad/datalad/pull/7014 as well as having neuroimaging and crawler test against the PR in core + this patch here. (Done in https://github.com/datalad/datalad-neuroimaging/pull/113 and https://github.com/datalad/datalad-crawler/pull/129).

Everything passed, so hopefully this finally was it regarding the move of metadata stuff into here.

github-actions[bot] commented 1 year ago

:rocket: PR was released in 0.2.7 :rocket: