search

datalad / datalad-deprecated

DataLad extension for functionality that has been phased out of the core package
Other
0 stars 3 forks source link

Move with_testrepos from core to deprecated #80

Closed adswa closed 1 year ago

adswa commented 1 year ago

According to https://github.com/datalad/datalad/issues/6752, @with_testrepos is only used inside of this extension's tests. This PR moves with_testrepos and its tests into this extension. It likewise moves make_studyforrest_mockup and its test into this extension, as it, too, was entirely unused in the core package.

I'm not 100% sure whether we actually want to keep make_studyforrest_mockup, I mostly included as it was a part of the test_testrepos testsuite that I set out to retire entirely to deprecated. Happy to strip this function and its test, if its deemed entirely irrelevant.

adswa commented 1 year ago

Can I get a review on this PR? I would be nice if this PR could be merged and released afterwards, so that the way is paved for https://github.com/datalad/datalad/issues/6752.

adswa commented 1 year ago

Thx. I've added labels for a release. The Changelog seems to be autogenerated by a bot, so I haven't added any. :crossed_fingers:

github-actions[bot] commented 1 year ago

:rocket: PR was released in 0.2.8 :rocket: