search

datalad / datalad-extension-template

Minimal implementation of a DataLad extension module
http://datalad.org
Other
2 stars 17 forks source link

Remove `--universal` flag #15

Closed jwodder closed 3 years ago

jwodder commented 3 years ago

The project metadata indicates that the template is for Python 3 only; thus, --universal should not be passed to bdist_wheel, as that option is only for projects that run on both Python 2 and Python 3.

mih commented 3 years ago

Thanks for the updates! However, it is unclear to me why the CI would fail now? I reran the CI just now on the base commit, and it completed fine. I presently have no idea how PEP517 does influence this proposed change.

codecov[bot] commented 3 years ago

Codecov Report

Merging #15 (ca31686) into master (0098853) will not change coverage. The diff coverage is n/a.

:exclamation: Current head ca31686 differs from pull request most recent head a6e5add. Consider uploading reports for the commit a6e5add to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   92.10%   92.10%           
=======================================
  Files           3        3           
  Lines          38       38           
=======================================
  Hits           35       35           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0098853...a6e5add. Read the comment docs.

mih commented 3 years ago

Reran CI after #17. Worked. Merged. Thx!