datalad / datalad-extension-template

Minimal implementation of a DataLad extension module
http://datalad.org
Other
2 stars 17 forks source link

Templates for using datalad/release-action #49

Closed jwodder closed 1 year ago

jwodder commented 1 year ago

Closes #48.

codecov[bot] commented 1 year ago

Codecov Report

Base: 92.85% // Head: 92.85% // No change to project coverage :thumbsup:

Coverage data is based on head (ba6b488) compared to base (1ea1de5). Patch has no changes to coverable lines.

:exclamation: Current head ba6b488 differs from pull request most recent head 236c0fa. Consider uploading reports for the commit 236c0fa to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #49 +/- ## ======================================= Coverage 92.85% 92.85% ======================================= Files 5 5 Lines 42 42 ======================================= Hits 39 39 Misses 3 3 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jwodder commented 1 year ago

@yarikoptic Ping.

yarikoptic commented 1 year ago

Looks good to me. @mih any suggestions/objections?

yarikoptic commented 1 year ago

Only the combination of active and no docs should be avoided.

agree

The changelog.d is dead-weight for people who don't use scriv, but it also does nothing in that case.

not really -- scriv would be used by action, so it would be "editable metadata for the release action" even if they don't use scriv directly.

@jwodder, please

jwodder commented 1 year ago

@yarikoptic Note that DataLad's CONTRIBUTING.md contains up-to-date information on the master branch but not on the maint branch, as https://github.com/datalad/datalad/pull/7204 was made against master (despite being after the default branch was changed). There are also various other differences between the two branches' versions of the file. What exactly should be done about this, and by whom?

jwodder commented 1 year ago

@yarikoptic

refer to CONTRIBUTING.md within README.md

Refer to it how? What exactly should be said?

yarikoptic commented 1 year ago

@yarikoptic

refer to CONTRIBUTING.md within README.md

Refer to it how? What exactly should be said?

in datalad we have

# Contributing

See [CONTRIBUTING.md](CONTRIBUTING.md) if you are interested in internals or
contributing to the project.

which sounds good to paste here.

There are also various other differences between the two branches' versions of the file. What exactly should be done about this, and by whom?

oh ok, nevermind then... @bpoldrack soon will cut new major minor release so it would become up to date... if doesn't happen then we would bring it up again.

yarikoptic commented 1 year ago

ok, I think this PR is ready. Added it to tomorrow's meetup agenda to seek feedback/blessing

mih commented 1 year ago

This is reading an extension for using the release action, but does not impose its use. All good with me. Thx!