Closed jwodder closed 1 year ago
Base: 92.85% // Head: 92.85% // No change to project coverage :thumbsup:
Coverage data is based on head (
ba6b488
) compared to base (1ea1de5
). Patch has no changes to coverable lines.:exclamation: Current head ba6b488 differs from pull request most recent head 236c0fa. Consider uploading reports for the commit 236c0fa to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@yarikoptic Ping.
Looks good to me. @mih any suggestions/objections?
Only the combination of active and no docs should be avoided.
agree
The
changelog.d
is dead-weight for people who don't usescriv
, but it also does nothing in that case.
not really -- scriv would be used by action, so it would be "editable metadata for the release action" even if they don't use scriv
directly.
@jwodder, please
auto
.@yarikoptic Note that DataLad's CONTRIBUTING.md
contains up-to-date information on the master
branch but not on the maint
branch, as https://github.com/datalad/datalad/pull/7204 was made against master
(despite being after the default branch was changed). There are also various other differences between the two branches' versions of the file. What exactly should be done about this, and by whom?
@yarikoptic
refer to CONTRIBUTING.md within README.md
Refer to it how? What exactly should be said?
@yarikoptic
refer to CONTRIBUTING.md within README.md
Refer to it how? What exactly should be said?
in datalad we have
# Contributing
See [CONTRIBUTING.md](CONTRIBUTING.md) if you are interested in internals or
contributing to the project.
which sounds good to paste here.
There are also various other differences between the two branches' versions of the file. What exactly should be done about this, and by whom?
oh ok, nevermind then... @bpoldrack soon will cut new major minor release so it would become up to date... if doesn't happen then we would bring it up again.
ok, I think this PR is ready. Added it to tomorrow's meetup agenda to seek feedback/blessing
This is reading an extension for using the release action, but does not impose its use. All good with me. Thx!
Closes #48.