search

datalad / datalad-extension-template

Minimal implementation of a DataLad extension module
http://datalad.org
Other
2 stars 17 forks source link

Appveyor setup: use venv in favor of virtualenv #76

Closed yarikoptic closed 1 year ago

yarikoptic commented 1 year ago

Ref: https://github.com/datalad/datalad-next/pull/446 and there on

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (4cfa233) 92.68% compared to head (7d3e2bc) 92.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ======================================= Coverage 92.68% 92.68% ======================================= Files 5 5 Lines 41 41 ======================================= Hits 38 38 Misses 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mih commented 1 year ago

Please see https://github.com/datalad/datalad-extension-template/issues/67#issuecomment-1711161094 -- this feature can be remove entirely

yarikoptic commented 1 year ago

IMHO it is ok to remove, especially after having it fixed to use standard venv so that if need comes back -- we are just 1 revert away. So let's proceed with merge since IMHO it is a right step forward even if to be removed right after.