datalad / datalad-extension-template

Minimal implementation of a DataLad extension module
http://datalad.org
Other
2 stars 17 forks source link

Remove unused CONTRIBUTORS file as well as references to it #87

Closed jsheunis closed 11 months ago

jsheunis commented 11 months ago

Updates:

Closes https://github.com/datalad/datalad-extension-template/issues/84

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (81dcfe5) 92.68% compared to head (3dfc2ca) 92.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #87 +/- ## ======================================= Coverage 92.68% 92.68% ======================================= Files 5 5 Lines 41 41 ======================================= Hits 38 38 Misses 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adswa commented 11 months ago

I have voiced a few reasons against this PR in the original issue. In summary, these were:

mslw commented 11 months ago

I understand where the PR is coming from in that the contributors file is unused (or rather: not used actively, i.e. not updated) across several DataLad projects, including core (3 yrs ago) and next, where zenodo.json became the de facto contributor list.

But the arguments presented by @adswa are compelling, and I would vote to keep the file in the template.

adswa commented 11 months ago

In the spirit of not leaving forgotten clutter around, I'll close this PR - but if there are new viewpoints that speak for this PR, let's reopen this and rekindle the discussion.