datalad / datalad-fuse

DataLad extension to provide FUSE file system access
Other
1 stars 4 forks source link

Cache getattr(); use a constant for cache size #26

Closed jwodder closed 2 years ago

jwodder commented 2 years ago

Closes #24.

codecov[bot] commented 2 years ago

Codecov Report

Merging #26 (e1b6ee6) into master (fc1a489) will increase coverage by 0.29%. The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   67.40%   67.70%   +0.29%     
==========================================
  Files           8        9       +1     
  Lines         540      545       +5     
==========================================
+ Hits          364      369       +5     
  Misses        176      176              
Impacted Files Coverage Δ
datalad_fuse/__init__.py 77.77% <0.00%> (ø)
datalad_fuse/consts.py 100.00% <100.00%> (ø)
datalad_fuse/fsspec.py 80.76% <100.00%> (+0.14%) :arrow_up:
datalad_fuse/fuse_.py 26.77% <100.00%> (+1.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae19e27...e1b6ee6. Read the comment docs.

yarikoptic commented 2 years ago

Did you see any benefit from it eg on those use cases you tried before?

jwodder commented 2 years ago

@yarikoptic I don't think I ever noticed any benefits from the caching, but I also didn't do any timing comparisons.

yarikoptic commented 2 years ago

Let's see if real life, thanks!