search

datalad / datalad-fuse

DataLad extension to provide FUSE file system access
Other
1 stars 4 forks source link

Assert that `datalad fusefs` test processes terminate quickly #67

Closed jwodder closed 2 years ago

jwodder commented 2 years ago

Closes #66.

codecov[bot] commented 2 years ago

Codecov Report

Merging #67 (50e994e) into master (fcc003f) will decrease coverage by 0.56%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   71.22%   70.65%   -0.57%     
==========================================
  Files          11       11              
  Lines         775      760      -15     
==========================================
- Hits          552      537      -15     
  Misses        223      223
Impacted Files Coverage Δ
datalad_fuse/tests/test_fuse.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6fe8b6...50e994e. Read the comment docs.

yarikoptic commented 2 years ago

I would have preferred if it would have channeled problematic case as AssertionError (as title of the PR says "assert") not subprocess.TimeoutExpired but that is ok - at least we will error out now if it does not quit in time.