datalad / datalad-gooey

A graphical user interface for DataLad (datalad.org)
https://docs.datalad.org/projects/gooey
Other
4 stars 6 forks source link

Get is silent for not-needed results #180

Open adswa opened 2 years ago

adswa commented 2 years ago

This is likely an issue for DataLad core, but it caught my attention in the context of the gooey and #179: Because a 'get --no-data' call on any file or directory does not seem to return any result record:

C:\Users\adina\repos\datalad-gooey\sf>datalad -f json_pp get -n sub-01/ses-localizer
<blank>

a get call from the gooey where one did not tick the 'get data' box in the parameter widget never reports any outcome in the Command Log. Here is an example with both a 'get --no-data' and 'get' call from the gooey:

Running: Dataset('C:\\Users\\adina\\books2').get(path=[WindowsPath('C:/Users/adina/books2/A.Shashua-Introduction_to_Machine_Learning.pdf')], recursion_limit=0, get_data=False, on_failure='ignore')

Running: Dataset('C:\\Users\\adina\\books2').get(path=[WindowsPath('C:/Users/adina/books2/A.Shashua-Introduction_to_Machine_Learning.pdf')], recursion_limit=0, on_failure='ignore')

This is on Windows 11, using datalad 0.17.3 and 0.17.6

get(ok): A.Shashua-Introduction_to_Machine_Learning.pdf (file) [from web...]

Thus, a user who runs get and forgets to set 'get data' might be under the impression that a command is running forever.

This is the default parametrization of get for me in complex and simple view. Screenshot from 2022-09-22 10-21-12 Screenshot from 2022-09-22 10-18-03

mih commented 2 years ago

I do not think we need to change result rendering. This is better done with an indicator in the tree view that marks files to be locally available vs not.