Simplistic (enforced) ASKPASS helper

datalad / datalad-gooey

A graphical user interface for DataLad (datalad.org)

https://docs.datalad.org/projects/gooey

Other

4 stars 6 forks source link

Simplistic (enforced) ASKPASS helper #186

Closed mih closed 2 years ago

mih commented 2 years ago

The new gooey-askpass command implements the traditional SSH_ASKPASS API. It opens a simple input dialog with the given prompt, collects input, and writes it to stdout.

Within Gooey this helper is not the enforced method for anything that honors a normal SSH_ASKPASS setup -- this includes Git and SSH.

So any such requests should now show up in the GUI, rather than be hidden in the terminal.

Closes datalad/datalad-gooey#177

adswa commented 2 years ago

This works on Debian (after reinstalling). I noticed that the password entry is not hidden, not sure if this is worth a future todo

adswa commented 2 years ago

On windows things that would require git credentials work out of the box for me (no pop ups), probably because I have a credential in gits credential helper...

mih commented 2 years ago

Good point re hidden entry. We could look for 'password' or 'token' in the supplied prompt and go hidden, if found.

mih commented 2 years ago

Thx!