search

datalad / datalad-gooey

A graphical user interface for DataLad (datalad.org)
https://docs.datalad.org/projects/gooey
Other
4 stars 6 forks source link

Loads of changes re parameter widgets #214

Closed mih closed 2 years ago

mih commented 2 years ago
codecov-commenter commented 2 years ago

Codecov Report

Base: 73.82% // Head: 73.59% // Decreases project coverage by -0.22% :warning:

Coverage data is based on head (42a4357) compared to base (431abd2). Patch coverage: 81.50% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #214 +/- ## ========================================== - Coverage 73.82% 73.59% -0.23% ========================================== Files 35 35 Lines 1830 1837 +7 ========================================== + Hits 1351 1352 +1 - Misses 479 485 +6 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-gooey/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_gooey/datalad\_ui.py](https://codecov.io/gh/datalad/datalad-gooey/pull/214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9kYXRhbGFkX3VpLnB5) | `60.37% <0.00%> (-1.17%)` | :arrow_down: | | [datalad\_gooey/dataladcmd\_ui.py](https://codecov.io/gh/datalad/datalad-gooey/pull/214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9kYXRhbGFkY21kX3VpLnB5) | `91.89% <0.00%> (ø)` | | | [datalad\_gooey/param\_widgets.py](https://codecov.io/gh/datalad/datalad-gooey/pull/214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9wYXJhbV93aWRnZXRzLnB5) | `69.85% <74.02%> (-2.67%)` | :arrow_down: | | [datalad\_gooey/param\_multival\_widget.py](https://codecov.io/gh/datalad/datalad-gooey/pull/214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9wYXJhbV9tdWx0aXZhbF93aWRnZXQucHk=) | `87.50% <89.02%> (-1.64%)` | :arrow_down: | | [datalad\_gooey/param\_form\_utils.py](https://codecov.io/gh/datalad/datalad-gooey/pull/214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9wYXJhbV9mb3JtX3V0aWxzLnB5) | `88.29% <100.00%> (+1.48%)` | :arrow_up: | | [datalad\_gooey/tests/test\_param\_widget.py](https://codecov.io/gh/datalad/datalad-gooey/pull/214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS90ZXN0cy90ZXN0X3BhcmFtX3dpZGdldC5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

adswa commented 2 years ago

I can select files and directories successfully (without a crash) on 17ef7f81604d30fb76808dc4bc799b81d58a6075

mih commented 2 years ago

Given that the crash is gone, I think this is useful to merge, even if it still has some (new) hidden issues.