datalad / datalad-gooey

A graphical user interface for DataLad (datalad.org)
https://docs.datalad.org/projects/gooey
Other
4 stars 6 forks source link

Last clicked tree item should be retained even if `Properties` tab is not active #252

Open jsheunis opened 1 year ago

jsheunis commented 1 year ago

Testing this on a mac: 3d36d940241bdd9166d1e6c3202fe6e35246a9e0

  1. Open the properties tab
  2. Click on several tree items and see their paths displayed in the properties tab, e.g. No information on /Users/jsheunis/Documents/psyinf/Data/sfdata15Jul2022 (last item clicked)
  3. Click on the command tab
  4. Click on another tree item
  5. Click on the properties tab again -> now the last clicked item before the the tabs were changed from properties to commands is still shown, and not the last clicked item (i.e. currently selected).

I'm guessing the code that generates the No information on <path> should probably also be run when selecting the properties tab, using the globally last clicked (or currently selected) item.

Related to https://github.com/datalad/datalad-gooey/issues/193

mih commented 1 year ago

I'm guessing the code that generates the No information on should probably also be run when selecting the properties tab, using the globally last clicked (or currently selected) item.

Makes sense!

adswa commented 1 year ago

I can't replicate this on a Linux system with the current main branch.

adswa commented 1 year ago

Also not on a Windows machine