Closed mih closed 1 year ago
Base: 67.08% // Head: 65.56% // Decreases project coverage by -1.52%
:warning:
Coverage data is based on head (
12245e7
) compared to base (bab2db0
). Patch coverage: 65.03% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This change replaces the previously used mixin pattern for parameter input widget. Now the Gooey parameter representation and the input widget are two connected but separate entities.
GooeyCommandParameter
is the new base class that encapsulates all parameter value handling that is not internal to a single input widget.The validator/constraint integration is improved. Any parameter value change will now trigger a validation run of the entire command configuration form. Invalid parameter values are flagged with a visual indicator next to the parameter name. As long as invalid parameter values exist, command submission is prevented. Because this is done immediately, and continuously, users also get an immediate indication of require command parameters -- something that required trail-and-error before.
https://user-images.githubusercontent.com/136479/193989384-44a1797c-7eb6-4638-9cdd-a4ab22e6f85b.mp4