Closed christian-monch closed 1 year ago
(Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808) Wohoo! :tada: Thanks for opening your first pull request! :sunglasses: We really appreciate your time and effort to contribute to the project - you're amazing! :clap:
Base: 65.87% // Head: 65.87% // No change to project coverage :thumbsup:
Coverage data is based on head (
3e69cdf
) compared to base (3cf7dda
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
(Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808) Congrats on merging your first pull request! :tada: The DataLad Team appreciates your contribution greatly, and we want to say thanks! :sparkling_heart: Now go ahead and share your first merge with your colleagues, you got yourself this brag right! :smile: :gift:
Let's do it! What could go wrong? ;-)
Nothing ;-)
I should mention though, that we have to add an access token to the repository secrets that is authorized to create releases. It should be added to the "Secrets" for Actions, under the name TOKEN
, as shown in the image below:
Please let me know which scopes are needed for that, and I create one. Or which permissions you need to be able to do that yourself. Thx
@mih I added a token.
But I don't see the action in the Actions-tab. Do you?
It seems that first time contributer-workflows might have to be explicitly allowed:
I don't see it, but I am also not sure what to look for. I also don't know what the screenshot refers to that you posted. Can you link to that place or describe what it is that needs doing?
I fixed it by creating a branch in this repository that contains a very slight modification of the windows installer build-workflow. Since the workflow then comes from a "local" branch, it is automatically approved.
(I was referring to this chapter in github docs.)
Fixes #258
This PR moves the windows installer build-action into this repository. The windows installer build-action has to be triggered manually, where a revision ---by default
main
--- can be chosen from which the release should be built.The installer is deposited under a new release with a tag in the form ofwindows-<YYYYMMDDHHMM>-<version>
, e.g.The installer is deposited under the latest release. The name of the installer will be
datalad-gooey-<version>-installer-amd64.exe
, e.g. datalad-gooey-0.1.0+120.g34e85f6-installer-amd64.exe.and a name in the formwindows <YYYYMMDDHHMM>-<version>
(the timestamp and version are identical in the tag and the release name). For an example see this release in christian-monch/datalad-gooeyNB! the PR is difficult to test before merging because GitHub looks only in
main
for actions. It is working on my fork of this repository, where I merged the branchissue-258-move-installer
intomain
.