datalad / datalad-gooey

A graphical user interface for DataLad (datalad.org)
https://docs.datalad.org/projects/gooey
Other
4 stars 6 forks source link

WIN: add uninstaller #327

Closed adswa closed 1 year ago

adswa commented 1 year ago

This adds an uninstall section to the nsi script, following https://nsis.sourceforge.io/Docs/Chapter4.html#UninstallSection. I'm a bit unsure how to best test this - with the way the workflow to build the installer is currently set up, this would need to be merged and then manually triggered.

See #326 for the reasoning.

codecov-commenter commented 1 year ago

Codecov Report

Base: 62.57% // Head: 63.97% // Increases project coverage by +1.39% :tada:

Coverage data is based on head (40b369e) compared to base (1b917a3). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #327 +/- ## ========================================== + Coverage 62.57% 63.97% +1.39% ========================================== Files 47 47 Lines 3217 3217 ========================================== + Hits 2013 2058 +45 + Misses 1204 1159 -45 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-gooey/pull/327?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_gooey/dataladcmd\_exec.py](https://codecov.io/gh/datalad/datalad-gooey/pull/327/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9kYXRhbGFkY21kX2V4ZWMucHk=) | `86.79% <0.00%> (+3.77%)` | :arrow_up: | | [datalad\_gooey/app.py](https://codecov.io/gh/datalad/datalad-gooey/pull/327/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9hcHAucHk=) | `68.87% <0.00%> (+4.14%)` | :arrow_up: | | [datalad\_gooey/fsbrowser.py](https://codecov.io/gh/datalad/datalad-gooey/pull/327/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9mc2Jyb3dzZXIucHk=) | `39.20% <0.00%> (+11.15%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

adswa commented 1 year ago

@christian-monch I believe you'll add an uninstaller to the re-implementation of the installer you mentioned today, so I assume I can close this, right? Please reopen, or reuse what ever you deem useful from this PR :)

adswa commented 1 year ago

I think there is no uninstaller section in the current installer yet, right @christian-monch? Do you think this PR is worthwhile reincarnating?