Closed adswa closed 1 year ago
Base: 62.57% // Head: 63.97% // Increases project coverage by +1.39%
:tada:
Coverage data is based on head (
40b369e
) compared to base (1b917a3
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@christian-monch I believe you'll add an uninstaller to the re-implementation of the installer you mentioned today, so I assume I can close this, right? Please reopen, or reuse what ever you deem useful from this PR :)
I think there is no uninstaller section in the current installer yet, right @christian-monch? Do you think this PR is worthwhile reincarnating?
This adds an uninstall section to the nsi script, following https://nsis.sourceforge.io/Docs/Chapter4.html#UninstallSection. I'm a bit unsure how to best test this - with the way the workflow to build the installer is currently set up, this would need to be merged and then manually triggered.
See #326 for the reasoning.