Dropping a subdataset (in full) does not refresh the tree

datalad / datalad-gooey

A graphical user interface for DataLad (datalad.org)

https://docs.datalad.org/projects/gooey

Other

4 stars 6 forks source link

Dropping a subdataset (in full) does not refresh the tree #335

Closed mih closed 1 year ago

mih commented 1 year ago

This may be the result of a confusion. For a subdataset that was dropped in-full, where the tree item is not expanded, the only thing that could change is the "State" annotation. Right now it keeps saying "clean". Maybe it should switch to "absent"?

mih commented 1 year ago

We have the exact same issue in reverse for get. The subdataset record remains "absent". In both cases, the underlying command does not touch the subdataset's root folder -- so when the corresponding item is not expanded, gooey does not get notified.

We need a patch analog to datalad_gooey/patches/clone.py it seems.

mih commented 1 year ago

After https://github.com/datalad/datalad-gooey/pull/348 this is only an issue for directory items that have never been expanded

mih commented 1 year ago

No longer an issue (tested with 40bf82f71e2e6e2e8292bc8622df385a34ee4135)