datalad / datalad-gooey

A graphical user interface for DataLad (datalad.org)
https://docs.datalad.org/projects/gooey
Other
4 stars 6 forks source link

Detect to be deleted credential properties, and delete them #366

Closed mih closed 1 year ago

mih commented 1 year ago

For that we need to compare against the stored credential, and set all vanished properties to None.

Closes datalad/datalad-gooey#355

codecov-commenter commented 1 year ago

Codecov Report

Base: 61.65% // Head: 61.84% // Increases project coverage by +0.19% :tada:

Coverage data is based on head (728b7e6) compared to base (19ef21a). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #366 +/- ## ========================================== + Coverage 61.65% 61.84% +0.19% ========================================== Files 48 48 Lines 3359 3418 +59 ========================================== + Hits 2071 2114 +43 - Misses 1288 1304 +16 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-gooey/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_gooey/credentials.py](https://codecov.io/gh/datalad/datalad-gooey/pull/366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9jcmVkZW50aWFscy5weQ==) | `12.69% <0.00%> (-0.42%)` | :arrow_down: | | [datalad\_gooey/param\_form\_utils.py](https://codecov.io/gh/datalad/datalad-gooey/pull/366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9wYXJhbV9mb3JtX3V0aWxzLnB5) | `84.93% <0.00%> (-0.79%)` | :arrow_down: | | [datalad\_gooey/param\_multival.py](https://codecov.io/gh/datalad/datalad-gooey/pull/366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9wYXJhbV9tdWx0aXZhbC5weQ==) | `58.62% <0.00%> (+6.34%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.