datalad / datalad-gooey

A graphical user interface for DataLad (datalad.org)
https://docs.datalad.org/projects/gooey
Other
4 stars 6 forks source link

Annotate symlinks with their targets #372

Closed mih closed 1 year ago

mih commented 1 year ago

Until now, symlinks were just labeled as such with no indication of their nature.

This change annotates symlinks, both in terms of lsdir results and their representation in the FS tree, with their targets.

While a user still cannot "follow" them within the Gooey, they can at least see what is going on.

Before status annotation, also annex'ed files are marked up in this fashion, because I see no need to make an expensive special case for that.

Closes datalad/datalad-gooey#23

Double-click event on a symlink pointing to a directory that is also in the tree view will jump to the respective item as current. If there is no target item yet, it will jump to the closest existing one.

New look: image

Behavior with annexed files:

https://user-images.githubusercontent.com/136479/195970884-7e394a36-1402-4d07-8415-60620d503c8e.mp4

codecov-commenter commented 1 year ago

Codecov Report

Base: 61.65% // Head: 61.30% // Decreases project coverage by -0.35% :warning:

Coverage data is based on head (88beaab) compared to base (2868351). Patch coverage: 30.55% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #372 +/- ## ========================================== - Coverage 61.65% 61.30% -0.36% ========================================== Files 48 48 Lines 3377 3411 +34 ========================================== + Hits 2082 2091 +9 - Misses 1295 1320 +25 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-gooey/pull/372?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_gooey/fsbrowser.py](https://codecov.io/gh/datalad/datalad-gooey/pull/372/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9mc2Jyb3dzZXIucHk=) | `26.40% <4.54%> (-1.72%)` | :arrow_down: | | [datalad\_gooey/fsbrowser\_item.py](https://codecov.io/gh/datalad/datalad-gooey/pull/372/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9mc2Jyb3dzZXJfaXRlbS5weQ==) | `85.57% <57.14%> (-2.18%)` | :arrow_down: | | [datalad\_gooey/lsdir.py](https://codecov.io/gh/datalad/datalad-gooey/pull/372/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9sc2Rpci5weQ==) | `90.19% <85.71%> (-0.43%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.