search

datalad / datalad-gooey

A graphical user interface for DataLad (datalad.org)
https://docs.datalad.org/projects/gooey
Other
4 stars 6 forks source link

Use datalad-gooey-askpass in Windows #380

Closed christian-monch closed 1 year ago

christian-monch commented 1 year ago

This PR fixes #371

The PR enables ash in the windows version of datalad-gooey to interact with users graphically, using datalad-gooey-askpass. It sets the environment variable $env:DISPLAY in the Windows-specific starting script, which seems to be required to trigger the Windows openssh client to use $env:SSH_ASKPASS, even if $env:SSH_ASKPASS_REQUIRE is set to force.

The change is done in the Windows-specific starting script in oder to not mess with $DISPLAY on X11-ish systems.

codecov-commenter commented 1 year ago

Codecov Report

Base: 61.30% // Head: 61.30% // No change to project coverage :thumbsup:

Coverage data is based on head (2ddd93a) compared to base (26cba1f). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #380 +/- ## ======================================= Coverage 61.30% 61.30% ======================================= Files 48 48 Lines 3411 3411 ======================================= Hits 2091 2091 Misses 1320 1320 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mih commented 1 year ago

I opened https://github.com/datalad/datalad-gooey/pull/383 as an alternative. I think this one would only fix installations performed with the installer, but not regular pip installs. @christian-monch WDYT?

christian-monch commented 1 year ago

I opened #383 as an alternative. I think this one would only fix installations performed with the installer, but not regular pip installs. @christian-monch WDYT?

I wholeheartedly agree, closing this one without merging.

This PR is superseeded b #383