datalad / datalad-gooey

A graphical user interface for DataLad (datalad.org)
https://docs.datalad.org/projects/gooey
Other
4 stars 6 forks source link

Use password echo-mode in datalad-gooey-askpass #382

Closed christian-monch closed 1 year ago

christian-monch commented 1 year ago

This PR fixes #371

The PR modifies the echo mode of the text entry in datalad-gooey-askpass, to "password echo-mode". As a result the entered password is not visible in clear anymore.

This should be more suitable for demonstrations ;-)

codecov-commenter commented 1 year ago

Codecov Report

Base: 61.30% // Head: 61.30% // No change to project coverage :thumbsup:

Coverage data is based on head (d6c40fa) compared to base (26cba1f). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #382 +/- ## ======================================= Coverage 61.30% 61.30% ======================================= Files 48 48 Lines 3411 3411 ======================================= Hits 2091 2091 Misses 1320 1320 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-gooey/pull/382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_gooey/askpass.py](https://codecov.io/gh/datalad/datalad-gooey/pull/382/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9hc2twYXNzLnB5) | `62.50% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.