search

datalad / datalad-gooey

A graphical user interface for DataLad (datalad.org)
https://docs.datalad.org/projects/gooey
Other
4 stars 6 forks source link

NF: Open terminal "here" via context menu #391

Closed christian-monch closed 1 year ago

christian-monch commented 1 year ago

This PR adds code to open a terminal in the context menu of a directory. The terminal shell will have an almost identical environment as the process that starts the terminal and the current working directory will be the path of the item that holds the context menu.

codecov-commenter commented 1 year ago

Codecov Report

Base: 61.11% // Head: 60.62% // Decreases project coverage by -0.49% :warning:

Coverage data is based on head (1e2f7cc) compared to base (c6d59c2). Patch coverage: 19.14% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #391 +/- ## ========================================== - Coverage 61.11% 60.62% -0.50% ========================================== Files 49 49 Lines 3467 3512 +45 ========================================== + Hits 2119 2129 +10 - Misses 1348 1383 +35 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-gooey/pull/391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_gooey/fsbrowser.py](https://codecov.io/gh/datalad/datalad-gooey/pull/391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9mc2Jyb3dzZXIucHk=) | `27.50% <0.00%> (-0.62%)` | :arrow_down: | | [datalad\_gooey/utils.py](https://codecov.io/gh/datalad/datalad-gooey/pull/391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS91dGlscy5weQ==) | `36.25% <19.51%> (-17.60%)` | :arrow_down: | | [datalad\_gooey/app.py](https://codecov.io/gh/datalad/datalad-gooey/pull/391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9hcHAucHk=) | `61.42% <20.00%> (-0.76%)` | :arrow_down: | | [datalad\_gooey/dataladcmd\_exec.py](https://codecov.io/gh/datalad/datalad-gooey/pull/391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9kYXRhbGFkY21kX2V4ZWMucHk=) | `85.58% <0.00%> (+2.70%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

christian-monch commented 1 year ago

Quick comment: Would be good to move all methods but the main slot out of app.py and into utils.py or utility_actions.py in the final version. Thx!

That's the spirit :-) Totally agree and ... done. (We should have more of that in another large project of ours ;-) )