datalad / datalad-gooey

A graphical user interface for DataLad (datalad.org)
https://docs.datalad.org/projects/gooey
Other
4 stars 6 forks source link

BF: Fix encoding issue on Windows #404

Closed adswa closed 1 year ago

adswa commented 1 year ago

passing an encoding specifically fixes #375 - I suspect that Windows doesn't communicate its preferred encoding, so let's be explicit. Thx to @christian-monch for the pointer.

image

codecov-commenter commented 1 year ago

Codecov Report

Base: 61.09% // Head: 60.62% // Decreases project coverage by -0.47% :warning:

Coverage data is based on head (6bd04e8) compared to base (38255be). Patch coverage: 19.14% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #404 +/- ## ========================================== - Coverage 61.09% 60.62% -0.48% ========================================== Files 49 49 Lines 3465 3512 +47 ========================================== + Hits 2117 2129 +12 - Misses 1348 1383 +35 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-gooey/pull/404?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_gooey/fsbrowser.py](https://codecov.io/gh/datalad/datalad-gooey/pull/404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9mc2Jyb3dzZXIucHk=) | `27.50% <0.00%> (-0.10%)` | :arrow_down: | | [datalad\_gooey/history\_widget.py](https://codecov.io/gh/datalad/datalad-gooey/pull/404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9oaXN0b3J5X3dpZGdldC5weQ==) | `50.00% <ø> (ø)` | | | [datalad\_gooey/utils.py](https://codecov.io/gh/datalad/datalad-gooey/pull/404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS91dGlscy5weQ==) | `36.25% <19.51%> (-17.60%)` | :arrow_down: | | [datalad\_gooey/app.py](https://codecov.io/gh/datalad/datalad-gooey/pull/404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9hcHAucHk=) | `61.42% <20.00%> (-0.76%)` | :arrow_down: | | [datalad\_gooey/dataladcmd\_exec.py](https://codecov.io/gh/datalad/datalad-gooey/pull/404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9nb29leS9kYXRhbGFkY21kX2V4ZWMucHk=) | `85.58% <0.00%> (+2.70%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.