search

datalad / datalad-installer

Installation script for Datalad and related components
MIT License
6 stars 3 forks source link

Mark some tests as impossible to pass on conda-forge #109

Closed jwodder closed 2 years ago

jwodder commented 2 years ago

The latest PR to update the conda-forge recipe (https://github.com/conda-forge/datalad-installer-feedstock/pull/4) is currently failing because two of the tests require passwordless sudo to work, which conda-forge's CI environment does not provide. This PR marks the tests as not passable on conda-forge.

After this PR is merged & released, the pytest commands in recipe/test.{sh,bat} in the feedstock will need to be updated to use -m "not miniconda and not needs_sudo" instead of just -m "not miniconda".

codecov-commenter commented 2 years ago

Codecov Report

Merging #109 (d8a38dc) into master (15d808c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   65.80%   65.80%           
=======================================
  Files           1        1           
  Lines        1351     1351           
  Branches      296      296           
=======================================
  Hits          889      889           
  Misses        383      383           
  Partials       79       79

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15d808c...d8a38dc. Read the comment docs.

yarikoptic commented 2 years ago

Thank you @jwodder !

yarikoptic commented 2 years ago

marked for release since would simplify updating conda recipe (avoid needing a patch)