search

datalad / datalad-installer

Installation script for Datalad and related components
MIT License
6 stars 3 forks source link

Use GitHub token when downloading workflow artifacts #111

Closed jwodder closed 2 years ago

jwodder commented 2 years ago

Fixes the problem reported in https://github.com/datalad/datalad-extensions/issues/101.

Note that the test of git-annex:tested for Windows had to be marked as xfailing because there hasn't been a successful Windows build of datalad/git-annex for four months, and so the latest run's artifacts have expired.

codecov-commenter commented 2 years ago

Codecov Report

Merging #111 (70a3146) into master (5e8eec0) will decrease coverage by 0.96%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   65.80%   64.84%   -0.97%     
==========================================
  Files           1        1              
  Lines        1351     1351              
  Branches      296      277      -19     
==========================================
- Hits          889      876      -13     
- Misses        383      389       +6     
- Partials       79       86       +7
Impacted Files Coverage Δ
src/datalad_installer.py 64.84% <100.00%> (-0.97%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e8eec0...70a3146. Read the comment docs.

yarikoptic commented 2 years ago

Thank you @jwodder ! I am not certain though on how such a bug could sneak in, i.e. don't we have tests covering that installation use case?

jwodder commented 2 years ago

@yarikoptic Not previously; I added tests in the PR.