search

datalad / datalad-installer

Installation script for Datalad and related components
MIT License
6 stars 3 forks source link

Give miniconda component a `--python-match` option #114

Closed jwodder closed 2 years ago

jwodder commented 2 years ago

Closes #113.

codecov-commenter commented 2 years ago

Codecov Report

Merging #114 (36ba502) into master (c2f24fa) will decrease coverage by 0.91%. The diff coverage is 7.14%.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   68.17%   67.25%   -0.92%     
==========================================
  Files           1        1              
  Lines        1351     1365      +14     
  Branches      296      301       +5     
==========================================
- Hits          921      918       -3     
- Misses        347      364      +17     
  Partials       83       83
Impacted Files Coverage Δ
src/datalad_installer.py 67.25% <7.14%> (-0.92%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2f24fa...36ba502. Read the comment docs.

yarikoptic commented 2 years ago

could you please add or augment at least one test run with --python-match option so we would get this code test covered and altogether ensure that we could actually achieve that for miniconda env. Meanwhile I will test locally "manually"

yarikoptic commented 2 years ago

I have tested 

python3.8 src/datalad_installer.py -E /tmp/test-miniconda.sh miniconda --batch --path=/tmp/test-miniconda --python-match minor git-annex=8.20201007 -m conda

with the #115 merged and it worked out nicely! Let's release and get test after to ensure that nothing breaks this wonderful behavior ;)