Make compatible with arm64 brew, test on older and latest macos, strip away no longer needed windows test env exclusion

datalad / datalad-installer

Installation script for Datalad and related components

MIT License

6 stars 3 forks source link

Make compatible with arm64 brew, test on older and latest macos, strip away no longer needed windows test env exclusion #197

Closed yarikoptic closed 4 months ago

yarikoptic commented 4 months ago

expecting that macos-latest testing would not succeed. We might want to add explicitly macos-12 and then new macos-latest which would be arm

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.53%. Comparing base (d35969d) to head (5d70ec7).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #197 +/- ## ========================================== - Coverage 65.69% 65.53% -0.16% ========================================== Files 1 1 Lines 1644 1648 +4 Branches 408 409 +1 ========================================== Hits 1080 1080 - Misses 461 465 +4 Partials 103 103 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mslw commented 4 months ago

I think that does it - all checks, including macos-latest, passed.

For additional verification, I tried this in a stripped-out test run on macos-latest (i.e. macos-14-arm64) in a throwaway repo: install the installer from this branch with pip, install git-annex with the installer, install DataLad with pip, and, instead of tests, only run which and ask about versions. It gave me the following, suggesting everything lands correctly on PATH:

/Users/runner/hostedtoolcache/Python/3.11.9/arm64/bin/datalad
/opt/homebrew/bin/git
/opt/homebrew/bin/git-annex
datalad 1.0.2
git version 2.44.0
git-annex version: 10.20240227

I'd say it's good to go.

yarikoptic commented 4 months ago

dropped TEMP commit, force pushed, adjusted title to reflect included changes, marking for release.

mslw commented 4 months ago

@yarikoptic the release action crashed - what on earth happened there? https://github.com/datalad/datalad-installer/actions/runs/8834788909/job/24257350453

edit: ok, I think I know. For some reason the release workflow downloads an old version of auto; the issue manifested recently (some change on GitHub side?) and the latest (actually two patches back) release addressed it... Will open an issue with more details or go straight to PR.

yarikoptic commented 4 months ago

merged my "fix" #198 , waiting on result

mslw commented 4 months ago

I also just realized that the version was simply pinned - I'll keep my fingers crossed :crossed_fingers:

yarikoptic commented 4 months ago

FWIW -- 1.0.5 was just released so all is good. I am rerunning brew job I had https://github.com/datalad/datalad/actions/runs/8820905835?pr=7586 in https://github.com/datalad/datalad/pull/7586 which if passes is IMHO worth merging to get us 1 step closer there