datalad / datalad-neuroimaging

DataLad extension for neuroimaging research
http://datalad.org
Other
17 stars 14 forks source link

Bring the extension up to date with datalad-extension-template #101

Closed mslw closed 2 years ago

mslw commented 2 years ago

This WIP PR attempts to bring the extension in line with the datalad-extension-template; fix #99. In summary, the biggest changes affect:

What was done and how

I also tried to keep the commit messages descriptive, so that may be a good way to learn what was changed.

What I was able to verify

Attention for the reviewers

codecov[bot] commented 2 years ago

Codecov Report

Merging #101 (69c8a68) into master (d04807c) will increase coverage by 85.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #101       +/-   ##
===========================================
+ Coverage        0   85.12%   +85.12%     
===========================================
  Files           0       21       +21     
  Lines           0     1049     +1049     
===========================================
+ Hits            0      893      +893     
- Misses          0      156      +156     
Impacted Files Coverage Δ
datalad_neuroimaging/__init__.py 100.00% <100.00%> (ø)
datalad_neuroimaging/_version.py 100.00% <100.00%> (ø)
datalad_neuroimaging/tests/test_procedure.py 100.00% <0.00%> (ø)
datalad_neuroimaging/tests/test_register.py 100.00% <0.00%> (ø)
datalad_neuroimaging/tests/test_dicomconv.py 96.42% <0.00%> (ø)
...atalad_neuroimaging/extractors/tests/test_dicom.py 94.54% <0.00%> (ø)
datalad_neuroimaging/extractors/tests/test_nidm.py 100.00% <0.00%> (ø)
datalad_neuroimaging/bids2scidata.py 73.35% <0.00%> (ø)
datalad_neuroimaging/tests/test_bids2scidata.py 96.77% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d04807c...69c8a68. Read the comment docs.

mslw commented 2 years ago

I've updated my PR description, and I think this is ready - for review at least.

As a side note, I had to restart the linux build on appveyor because it failed after being stuck for like an hour on "Build started", but on the second run it completed without any issues (3,5 minutes) so it must have been some glitch in appveyor.