search

datalad / datalad-neuroimaging

DataLad extension for neuroimaging research
http://datalad.org
Other
17 stars 14 forks source link

Update extractors #108

Closed christian-monch closed 1 year ago

christian-monch commented 1 year ago

This PR updates the extractors to work with current numpy versions.

codecov[bot] commented 1 year ago

Codecov Report

Base: 40.11% // Head: 85.58% // Increases project coverage by +45.46% :tada:

Coverage data is based on head (0cc42dd) compared to base (cd1ab4a). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #108 +/- ## =========================================== + Coverage 40.11% 85.58% +45.46% =========================================== Files 23 23 Lines 1214 1214 =========================================== + Hits 487 1039 +552 + Misses 727 175 -552 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/108?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_neuroimaging/extractors/nifti1.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/108/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvZXh0cmFjdG9ycy9uaWZ0aTEucHk=) | `89.65% <ø> (+89.65%)` | :arrow_up: | | [datalad\_neuroimaging/extractors/tests/test\_bids.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/108/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvZXh0cmFjdG9ycy90ZXN0cy90ZXN0X2JpZHMucHk=) | `100.00% <100.00%> (+52.63%)` | :arrow_up: | | [...neuroimaging/extractors/tests/test\_bids\_dataset.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/108/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvZXh0cmFjdG9ycy90ZXN0cy90ZXN0X2JpZHNfZGF0YXNldC5weQ==) | `100.00% <100.00%> (ø)` | | | [...atalad\_neuroimaging/extractors/tests/test\_dicom.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/108/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvZXh0cmFjdG9ycy90ZXN0cy90ZXN0X2RpY29tLnB5) | `94.54% <100.00%> (+54.54%)` | :arrow_up: | | [datalad\_neuroimaging/extractors/tests/test\_nidm.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/108/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvZXh0cmFjdG9ycy90ZXN0cy90ZXN0X25pZG0ucHk=) | `100.00% <100.00%> (+50.00%)` | :arrow_up: | | [...talad\_neuroimaging/extractors/tests/test\_nifti1.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/108/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvZXh0cmFjdG9ycy90ZXN0cy90ZXN0X25pZnRpMS5weQ==) | `94.44% <100.00%> (+36.11%)` | :arrow_up: | | [datalad\_neuroimaging/tests/test\_aggregation.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/108/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvdGVzdHMvdGVzdF9hZ2dyZWdhdGlvbi5weQ==) | `100.00% <100.00%> (+47.82%)` | :arrow_up: | | [datalad\_neuroimaging/tests/test\_bids2scidata.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/108/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvdGVzdHMvdGVzdF9iaWRzMnNjaWRhdGEucHk=) | `96.77% <100.00%> (+37.09%)` | :arrow_up: | | [datalad\_neuroimaging/tests/test\_dicomconv.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/108/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvdGVzdHMvdGVzdF9kaWNvbWNvbnYucHk=) | `96.42% <100.00%> (+28.57%)` | :arrow_up: | | [datalad\_neuroimaging/tests/test\_search.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/108/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvdGVzdHMvdGVzdF9zZWFyY2gucHk=) | `86.41% <100.00%> (+45.67%)` | :arrow_up: | | ... and [15 more](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/108/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

yarikoptic commented 1 year ago

cool, it is green... we are yet to migrate it to pytest though... Cheers and thanks !