Closed yarikoptic closed 1 year ago
seems to be ok, besides that "gen4" issue . refs: https://github.com/datalad/datalad/pull/7001 (better but not complete), https://github.com/datalad/datalad/pull/7079 (ugly but works)
Base: 85.58% // Head: 89.47% // Increases project coverage by +3.88%
:tada:
Coverage data is based on head (
337609a
) compared to base (3e78e5b
). Patch coverage: 97.95% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
skipped also most of the tests on crippled fs
That seems a bit suspicious. Did they not pass before? The crippled FS run isn't new here, so what changed?
I don't know and have no time to figure it dig out ATM given that they were even almost completely killed in datalad-deprecated. Figuring that out would be welcomed though! but given that tests already have some kind of skip on windows, I guess -- something which was not working reliably anyways -- for that the hint is that https://github.com/datalad/datalad-neuroimaging/actions/runs/3067753527 was the last ok run a month ago, was tested using datalad 0.16.7 and indeed a sample test
2022-09-16T12:15:30.4037902Z datalad_neuroimaging.extractors.tests.test_nidm.test_nidm ... ok
which started to fail was ok. So indeed might be some particular fix up (e.g. may be adding handling of gen4 metadata) was the one to worry about.
Ok, let's proceed then. Guess switching the framework is more important.
for the failing test -- we might be doomed to skip it for now, but we cannot really delay that long