datalad / datalad-neuroimaging

DataLad extension for neuroimaging research
http://datalad.org
Other
17 stars 14 forks source link

Adapt to the move of metadata-code from `datalad` to `datalad-deprecated` #111

Closed christian-monch closed 1 year ago

christian-monch commented 1 year ago

This PR adapts the parts of datalad_neuroimaging that used the old metadata code, i.e. the code contained in datalad.metadata, to the new location of this code, i.e. datalad_deprecated.metadata.

christian-monch commented 1 year ago

Remaining errors should be fixed after datalad-deprecated is released with PR https://github.com/datalad/datalad-deprecated/pull/71

yarikoptic commented 1 year ago

Thank you ! I have merged and released deprecated 0.2.5 , you might like to add versioning to depends

codecov[bot] commented 1 year ago

Codecov Report

Base: 89.47% // Head: 89.61% // Increases project coverage by +0.14% :tada:

Coverage data is based on head (4a19c13) compared to base (c15d584). Patch coverage: 97.67% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #111 +/- ## ========================================== + Coverage 89.47% 89.61% +0.14% ========================================== Files 24 24 Lines 1159 1175 +16 ========================================== + Hits 1037 1053 +16 Misses 122 122 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_neuroimaging/tests/test\_procedure.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvdGVzdHMvdGVzdF9wcm9jZWR1cmUucHk=) | `100.00% <ø> (ø)` | | | [datalad\_neuroimaging/tests/test\_search.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvdGVzdHMvdGVzdF9zZWFyY2gucHk=) | `85.71% <92.85%> (+0.99%)` | :arrow_up: | | [datalad\_neuroimaging/bids2scidata.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvYmlkczJzY2lkYXRhLnB5) | `82.50% <100.00%> (+0.05%)` | :arrow_up: | | [datalad\_neuroimaging/extractors/bids.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvZXh0cmFjdG9ycy9iaWRzLnB5) | `88.34% <100.00%> (ø)` | | | [datalad\_neuroimaging/extractors/bids\_dataset.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvZXh0cmFjdG9ycy9iaWRzX2RhdGFzZXQucHk=) | `85.60% <100.00%> (ø)` | | | [datalad\_neuroimaging/extractors/dicom.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvZXh0cmFjdG9ycy9kaWNvbS5weQ==) | `91.57% <100.00%> (ø)` | | | [datalad\_neuroimaging/extractors/nidm.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvZXh0cmFjdG9ycy9uaWRtLnB5) | `100.00% <100.00%> (ø)` | | | [datalad\_neuroimaging/extractors/nifti1.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvZXh0cmFjdG9ycy9uaWZ0aTEucHk=) | `89.65% <100.00%> (ø)` | | | [datalad\_neuroimaging/tests/test\_aggregation.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvdGVzdHMvdGVzdF9hZ2dyZWdhdGlvbi5weQ==) | `100.00% <100.00%> (ø)` | | | [datalad\_neuroimaging/tests/test\_dicomconv.py](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9uZXVyb2ltYWdpbmcvdGVzdHMvdGVzdF9kaWNvbWNvbnYucHk=) | `100.00% <100.00%> (ø)` | | | ... and [1 more](https://codecov.io/gh/datalad/datalad-neuroimaging/pull/111/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

bpoldrack commented 1 year ago

Thx, @christian-monch! Merging ...