Test against 3.9 not EOLed 3.8, fix typo, compatibility with recent pydicom 3.x

yarikoptic commented 2 weeks ago

on mac - the same story with timing out/lengthy installation of git-annex as observed on

https://github.com/datalad/datalad/pull/7669

yet to figure out what those are about

yarikoptic commented 1 day ago

also to get it clean we need to resolve gotchas due to new pydicom 3.0.0 changing how to handle DICOMDIRs which we simply skip..

yarikoptic commented 16 hours ago

on mac we got

python -m coverage xml
Wrote XML report to coverage.xml
curl -Os $CODECOV_BINARY
chmod +x codecov
./codecov
/usr/local/Cellar/appveyor-build-agent/7.0.3293/bash-shell.sh: line 51: ./codecov: Bad CPU type in executable
Command exited with code 126
Running "on_finish" scripts
while [ -f ~/BLOCK ]; do sleep 5; done
Build failed

taking solution from https://github.com/datalad/datalad/pull/7649/files (I hate duplication!...)

codecov[bot] commented 5 hours ago

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.80%. Comparing base (c6a066e) to head (eeaa422). Report is 13 commits behind head on master.

Files with missing lines	Patch %	Lines
datalad_neuroimaging/extractors/dicom.py	76.47%	4 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #133 +/- ## ========================================== - Coverage 89.16% 88.80% -0.36% ========================================== Files 24 23 -1 Lines 1181 1170 -11 ========================================== - Hits 1053 1039 -14 - Misses 128 131 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 3 hours ago

codecov isn't happy but at least we got to green state -- let's proceed and even release (if still works ;) )

datalad / datalad-neuroimaging

Test against 3.9 not EOLed 3.8, fix typo, compatibility with recent pydicom 3.x #133

Codecov Report