search

datalad / datalad-neuroimaging

DataLad extension for neuroimaging research
http://datalad.org
Other
17 stars 14 forks source link

fresh pydicom started to cause troubles? #85

Closed yarikoptic closed 4 years ago

yarikoptic commented 4 years ago

first mentioned in PRs of main datalad, now in daily extensions builds:

  File "/opt/hostedtoolcache/Python/3.7.7/x64/lib/python3.7/imp.py", line 171, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 696, in _load
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/opt/hostedtoolcache/Python/3.7.7/x64/lib/python3.7/site-packages/datalad_neuroimaging/extractors/tests/test_dicom.py", line 13, in <module>
    from datalad_neuroimaging.extractors.dicom import MetadataExtractor as DicomExtractor
  File "/opt/hostedtoolcache/Python/3.7.7/x64/lib/python3.7/site-packages/datalad_neuroimaging/extractors/dicom.py", line 39, in <module>
    dcm.valuerep.PersonName3)
AttributeError: module 'pydicom.valuerep' has no attribute 'PersonName3'

e.g. on https://github.com/datalad/datalad-extensions/runs/722270660

bpoldrack commented 4 years ago

Yes, release notes state, that PersonName3 was deprecated by pydicom 2.0.0. However, it actually claims to provide an alias. Those failures suggest that's not true. Note, that this also affects datalad-hirni. Looking into it.