search

datalad / datalad-next

DataLad extension for new functionality and improved user experience
https://datalad.org
Other
6 stars 7 forks source link

Remove non-asserting test from align_pattern tests #731

Closed christian-monch closed 3 weeks ago

christian-monch commented 3 weeks ago

This PR deletes the test datalad_next.itertools.tests.test_align_pattern.test_performance, which did not assert any properties, but just printed some performance measurements.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.62%. Comparing base (5fb9054) to head (3642879). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #731 +/- ## ========================================== + Coverage 92.60% 92.62% +0.02% ========================================== Files 197 197 Lines 14549 14542 -7 Branches 2215 2212 -3 ========================================== - Hits 13473 13470 -3 + Misses 813 807 -6 - Partials 263 265 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mih commented 3 weeks ago

This code will be removed here. An analog change has already been applied at https://github.com/datalad/datasalad/commit/5d23a439e39af62a827248474e90c81c8ba1f953

Merging nevertheless. Thanks.