datalad / datalad-remake

Other
2 stars 3 forks source link

Remove `use_shell` feature #30

Open mih opened 5 days ago

mih commented 5 days ago

The example in the readme has

use_shell = 'true'
command = [
    "echo content: {first} > '{output}-1.txt'; echo content: {second} > '{output}-2.txt'",
]

I'd argue that this is functionality equivalent to

# no longer use: use_shell = 'true'
command = [
    "bash",
    "-c",
    "echo content: {first} > '{output}-1.txt'; echo content: {second} > '{output}-2.txt'",
]

This is arguably not more complicated, but much more explicit (and thereby robust), because the shell required is clearly identified.