datalad / datalad-ria

Adds functionality for RIA stores to DataLad
http://datalad.org
Other
0 stars 1 forks source link

test_ria_basics.py::test_version_check has been failing against 8.20200309 for a while #49

Open yarikoptic opened 1 year ago

yarikoptic commented 1 year ago

spotted that recent cron job failed, looked at https://app.travis-ci.com/github/datalad/datalad/jobs/576842693 and confirmed historically:

$> datalad foreach-dataset "git grep 'FAILED ../datalad/distributed/tests/test_ria_basics.py::test_version_check'  | grep cron || :"
foreach-dataset(ok): /mnt/datasets/datalad/ci/logs/2022 (dataset)
03/cron/20220603T193647/173dc6f/travis-14100-failed/11.txt:FAILED ../datalad/distributed/tests/test_ria_basics.py::test_version_check - ...
foreach-dataset(ok): /mnt/datasets/datalad/ci/logs/2022/01 (dataset)
06/cron/20220506T193505/9c6b62c/travis-14007-failed/11.txt:FAILED ../datalad/distributed/tests/test_ria_basics.py::test_version_check - ...
01/cron/20220701T193907/797dde3/travis-14182-failed/11.txt:FAILED ../datalad/distributed/tests/test_ria_basics.py::test_version_check - ...
13/cron/20220513T195020/84f979a/travis-14027-failed/11.txt:FAILED ../datalad/distributed/tests/test_ria_basics.py::test_version_check - ...
10/cron/20220610T193717/029f839/travis-14136-failed/11.txt:FAILED ../datalad/distributed/tests/test_ria_basics.py::test_version_check - ...
20/cron/20220520T193556/84f979a/travis-14036-failed/11.txt:FAILED ../datalad/distributed/tests/test_ria_basics.py::test_version_check - ...
17/cron/20220617T193730/797dde3/travis-14152-failed/11.txt:FAILED ../datalad/distributed/tests/test_ria_basics.py::test_version_check - ...
27/cron/20220527T193600/310fd9f/travis-14055-failed/11.txt:FAILED ../datalad/distributed/tests/test_ria_basics.py::test_version_check - ...
24/cron/20220624T193828/797dde3/travis-14163-failed/11.txt:FAILED ../datalad/distributed/tests/test_ria_basics.py::test_version_check - ...
foreach-dataset(ok): /mnt/datasets/datalad/ci/logs/2022/05 (dataset)
foreach-dataset(ok): /mnt/datasets/datalad/ci/logs/2022/06 (dataset)
08/cron/20220708T212936/1592cb3/travis-14248-failed/11.txt:FAILED ../datalad/distributed/tests/test_ria_basics.py::test_version_check - ...
foreach-dataset(ok): /mnt/datasets/datalad/ci/logs/2022/04 (dataset)
12/cron/20220712T215128/5a1c4bd/travis-14269-failed/11.txt:FAILED ../datalad/distributed/tests/test_ria_basics.py::test_version_check - ...
15/cron/20220715T194006/52e822a/travis-14276-failed/11.txt:FAILED ../datalad/distributed/tests/test_ria_basics.py::test_version_check - ...
foreach-dataset(ok): /mnt/datasets/datalad/ci/logs/2022/07 (dataset)
foreach-dataset(ok): /mnt/datasets/datalad/ci/logs/2022/03 (dataset)
foreach-dataset(ok): /mnt/datasets/datalad/ci/logs/2022/02 (dataset)

and seems to be spurious. Please have a look or annotate it to be skipped if annex version is too old (but still supported...)

bpoldrack commented 1 year ago

I tried to reproduce this in datalad/datalad#7236 but failed to.

In any case: The failure looks like a pytest issue to me. The exception is actually expected by the test, but somehow the with assert_raises((CommandError, IncompleteResultsError)) doesn't seem to work as intended. Not clear to me what's wrong here.

adswa commented 1 year ago

I haven't spotted a failure in recent builds