search

datalad / datalad-ukbiobank

Resources for working with UKBiobank as a DataLad dataset
MIT License
6 stars 12 forks source link

Support FreeSurfer data records #101

Closed loj closed 1 year ago

loj commented 1 year ago

This extends the BIDS mapping file to include the FreeSurfer data record (20263).

While adding this, I found a deprecated import for eval_results that broke tests. This fix is included as well.

Closes #99 Closes #100

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (342038d) 94.63% compared to head (59b5562) 94.63%.

:exclamation: Current head 59b5562 differs from pull request most recent head ef3d917. Consider uploading reports for the commit ef3d917 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #101 +/- ## ======================================= Coverage 94.63% 94.63% ======================================= Files 10 10 Lines 354 354 ======================================= Hits 335 335 Misses 19 19 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-ukbiobank/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_ukbiobank/ukb2bids\_map.py](https://codecov.io/gh/datalad/datalad-ukbiobank/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF91a2Jpb2JhbmsvdWtiMmJpZHNfbWFwLnB5) | `100.00% <ø> (ø)` | | | [datalad\_ukbiobank/init.py](https://codecov.io/gh/datalad/datalad-ukbiobank/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF91a2Jpb2JhbmsvaW5pdC5weQ==) | `100.00% <100.00%> (ø)` | | | [datalad\_ukbiobank/update.py](https://codecov.io/gh/datalad/datalad-ukbiobank/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF91a2Jpb2JhbmsvdXBkYXRlLnB5) | `94.89% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

loj commented 1 year ago

Thanks for the review and suggestion @adswa! I've made the change to tox.ini to warn instead of error out on deprecations.