datalad / datalad-ukbiobank

Resources for working with UKBiobank as a DataLad dataset
MIT License
6 stars 12 forks source link

Upgrade versioneer to 0.19 - might be more robust etc #73

Closed yarikoptic closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #73 (641269d) into master (ea4ef21) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files           9        9           
  Lines         339      339           
=======================================
  Hits          329      329           
  Misses         10       10           
Impacted Files Coverage Δ
datalad_ukbiobank/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea4ef21...641269d. Read the comment docs.

yarikoptic commented 3 years ago

so 0.19 isn't providing remedy, let's try devel

yarikoptic commented 3 years ago

ok, this mitigates with devel version of versioneer providing 0+unknown version but if any test relies on __version__ -- it would not be desired/acceptable. Disabling shallow clone could be an ultimate solution for use of versioneer. Filed https://github.com/python-versioneer/python-versioneer/issues/252 to possibly gain some ideas.

mih commented 3 years ago

CI is up again, after disabling the shallow cloning. Before we play with a dev version, let's wait for a conclusion in https://github.com/python-versioneer/python-versioneer/issues/252

I will close this PR for now. Thx @yarikoptic for debugging!