MNT: Remove eval_file_type (removed from core) from code base

datalad / datalad-ukbiobank

Resources for working with UKBiobank as a DataLad dataset

MIT License

6 stars 12 forks source link

MNT: Remove eval_file_type (removed from core) from code base #84

Closed adswa closed 2 years ago

adswa commented 2 years ago

https://github.com/datalad/datalad/pull/6738 removed the deprecated and almost unused internal eval_file_type parameter. This companion PR removes the (effectless) use of this parameter from datalad-ukbiobank (a change I regard as needed to interoperate with 0.16.4 and higher, but backwards compatible).

adswa commented 2 years ago

ping @loj @mih

bpoldrack commented 2 years ago

@adswa: Did you look into the test failures?

adswa commented 2 years ago

Yes, see #82, a wrong fix in #85, and the consecutive WIP PR in core

mih commented 2 years ago

We need to get pytest to make the CI run again after datalad 0.17. Will push shortly.

mih commented 2 years ago

https://github.com/datalad/datalad-ukbiobank/pull/86 shows that this is safe to merge. Thx!